Hey there! First of all, wanted to say thank you for the great mod!
I wanted to ask if there is currently any way we can add more minerals to the config in order to modify the bonuses for those gems and minerals as well. For example, The Geology Mod (Update 1.6) (https://www.nexusmods.com/stardewvalley/mods/21038) adds quite a few new gems and minerals, but there is no way to modify the drop rate for these, and MineForMore bonuses also don't apply to them. If it's not possible, it's totally okay. If you don't have time to make the changes, but you are okay with added help, happy to assist in adding in more capability.
can look into adding new minerals/gems. Probably can also look into making a more dynamic config options to allow users to add minerals and gems from other mods themselves.
*Edit I won't be adding support for that mod as currently I don't think I can get a reliable way to get event when those custom minerals are broken. Also I feel it's overkill on my end to have to support that mod as it already has a file called CustomOre.json that allows you to modify drop counts directly so there's no need to add that to my mod if that mod already supports it.
I did refactor my code to support dynamic configuration with some GMCM access to allow for adding stones/ores and categorize them as ore/gems/geodes but probably won't release as it doesn't add anything new to existing function.
I would recommend removing older version then install the latest version so that the previous config files are removed and only new config file remains.
If you still have issues with new config file I can look into the issue
I retest the reported bug with 2 different test cases 1. Ensure ore drops with copper, iron, gold ore works without profession. 2. Ensure ore drops with copper, iron, gold ore works With profession.
Not sure doesn't seem like there's any bugs with the ore drops at this time. It might just be that your using other mods that also modifies the same function as what my mod does, and so it doesn't work together with my mod, or if there is a certain case you find the bug exist that I didn't test let me know.
[game] An error occurred in the base update loop: NullReferenceException: Object reference not set to an instance of an object. at UpdateOreGemDropsPatch.ModifiedOnStoneDestroyed(String stoneId, Int32 x, Int32 y, Farmer who) in C:\Users\jesse\source\repos\MineforMore\Patches\UpdateOreGemDropsPatch.cs:line 267 at StardewValley.GameLocation.OnStoneDestroyed_PatchedBy<DaLion.Professions__Darkmushu.MineForMore__spacechase0.SpaceCore>(GameLocation this, String stoneId, Int32 x, Int32 y, Farmer who) at StardewValley.GameLocation.destroyObject(Vector2 tileLocation, Boolean hardDestroy, Farmer who) at StardewValley.Monsters.DustSpirit.behaviorAtGameTick_PatchedBy<DaLion.Professions>(DustSpirit this, GameTime time) at StardewValley.Monsters.Monster.update_PatchedBy<DaLion.Core__DaLion.Professions__PeacefulEnd.AlternativeTextures>(Monster this, GameTime time, GameLocation location) at StardewValley.GameLocation.updateCharacters(GameTime time) at StardewValley.GameLocation.updateEvenIfFarmerIsntHere_PatchedBy<DaLion.Core__prism99.aedenthorn.FarmAnimalHarvestHelper>(GameLocation this, GameTime time, Boolean ignoreWasUpdatedFlush) at StardewValley.Locations.MineShaft.updateEvenIfFarmerIsntHere(GameTime time, Boolean ignoreWasUpdatedFlush) at StardewValley.Locations.MineShaft.UpdateMines(GameTime time) at StardewValley.Game1.UpdateLocations_PatchedBy<spacechase0.SpaceCore>(Game1 this, GameTime time) at StardewValley.Game1._update_PatchedBy<Nature.NatureInTheValley>(Game1 this, GameTime gameTime) at StardewValley.Game1.Update(GameTime gameTime) at StardewModdingAPI.Framework.SCore.OnPlayerInstanceUpdating(SGame instance, GameTime gameTime, Action runUpdate) What kind of mistake is that?
thanks for reporting, I think this might be related to when a stone breaks it checks for a which farmer broke the stone and checks farmers profession to drop number or ores, but there can be cases where a farmer is not identified as the person who broke the stone, and so error occurred and so I'll have to add a check to handle when it isn't a farmer who breaks stone, I'll add a fix to this later tonight when I get some time.
Edit ** Bug resolved.
the other patch error with spacecore and delion im not sure on
Is this compatable with stardew valley expanded? I've installed it and the mines day 1 is set to true but I can't access the mines. Just wondering if it's because I have Stardew Valley Expanded installed as well
I'm about to use this mod, but ill just ask if is there a config where you can edit the price of gems and bars by a percentage? (I know that the level 10 professions can raise it), but i want to configure them without the profession. it's just that the price of gems and bars are wierdly cheap and unrealistic, (like the gold bar is worth 250, while the diamond is worth 750). like c'mon the melon in stardew is literally worth 250 which pisses me off lol.
This mod currently does not change sell price values of bars and gems, but you can use the config file to just have more gems and ore drop.
The mod does allow you to control the gem drop and ore drop count so you can just get more gems to sell to make up the difference. The blacksmith profession if learned also grant instant smelting as a recipe for more resource cost but if you change the ore drop in config file this shouldn't really affect the end results
I don't think it would matter much in that the formula I use doesn't matter if you have profession or not and your mining level doesn't matter if your using the AddStone values in the config file the values should always be added when stone breaks. See formula below.
Number is the amount of stone that would drop when you break a stone, MinerProfessionBonusOrePerLevel is 0 if you don't have mining profession or calculates amount per level.
Formula: Number = (int)((Number + MinerProfessionBonusOrePerLevel + Instance.Config.AddStone) * Instance.Config.MultiplyStone).
I would recommend turning off "TurnOnMaxLevelFrom10toUnlimited" my setting to see if that helps in case it messes with the other exp system. Or trying my previous version v1.0.2 which doesn't apply any profession checks and had simpler formula to drop ore.
stone and geodes work, it also spawns more coal nodes, but loot for coal and ore are unchanged (even with the other loot modifier settings) this seems to be caused by the spacecore luck skill mod
The drops seems to be working fine, not sure if it's compatible with that mod. The luck skill mod doesn't seem like it does much but add a few set of data with content patches, and that in itself should not affect this mod. That mod does have Spacecore as a dependency, and Spacecore has so many different code and so I'm not sure if it's compatible with it.
Some functions would work but some may not.. Based on the description in that mod it looks like the other mod has its own exp system for leveling. You can turn off the exp leveling in my mod in the config file to not affect their exp system.
For concerns on profession the other mod describes their mod as custom which I'm assuming they might add new profession ID. I actually don't add Id for my profession, I just check the vanilla professional ID is learn then apply my own mod logic and so I don't anticipate any compatibility issues here.
Some area where there might be compatability issues is that the other mod has a skill called upheaval which changes all nodes to a geode . I run a code to change nodes to a geode , gem or coal node as well and although both our set of code would run with various order, only 1 return value would be passed back into the game. If my code runs last my node is passed back and is created in the mine,, if their code is ran their nodes will be passed back and created in the mine. The game will run but the nodes generated will depend on which code is ran last.
This mod requires SMAPI to work. Once you've installed this mod and SMAPI, it should automatically work. This mod does not work on all stones, only the stones that normally would drop more than 1 stone at a time.
You can see the video In this mod to see that not all stone nodes dropped many stones only certain one drops it. I hope this helps.
40 comments
I wanted to ask if there is currently any way we can add more minerals to the config in order to modify the bonuses for those gems and minerals as well. For example, The Geology Mod (Update 1.6) (https://www.nexusmods.com/stardewvalley/mods/21038) adds quite a few new gems and minerals, but there is no way to modify the drop rate for these, and MineForMore bonuses also don't apply to them. If it's not possible, it's totally okay. If you don't have time to make the changes, but you are okay with added help, happy to assist in adding in more capability.
can look into adding new minerals/gems.Probably can also look into making a more dynamic config options to allow users to add minerals and gems from other mods themselves.
*Edit I won't be adding support for that mod as currently I don't think I can get a reliable way to get event when those custom minerals are broken. Also I feel it's overkill on my end to have to support that mod as it already has a file called CustomOre.json that allows you to modify drop counts directly so there's no need to add that to my mod if that mod already supports it.
I did refactor my code to support dynamic configuration with some GMCM access to allow for adding stones/ores and categorize them as ore/gems/geodes but probably won't release as it doesn't add anything new to existing function.
I got into trouble while using this mod, but I don't know how to fix it, so I'm leaving a post.
It works well for jewelry and regular stones.
It does not work on ores such as copper, silver, and gold.
I've also tried setting up the previous version of the mode.
I've tried to change it several times, but this issue hasn't been resolved
Do you have a solution?
If you still have issues with new config file I can look into the issue
But the problem didn't go away
Ores such as copper, silver, and gold
This mode does not apply
1. Ensure ore drops with copper, iron, gold ore works without profession.
2. Ensure ore drops with copper, iron, gold ore works With profession.
Not sure doesn't seem like there's any bugs with the ore drops at this time. It might just be that your using other mods that also modifies the same function as what my mod does, and so it doesn't work together with my mod, or if there is a certain case you find the bug exist that I didn't test let me know.
Both test cases passes see results:
The problem hasn't been solved
I'm not sure why, but I guess there's an impact from some other mod I'm using!
It's not dropped in copper, iron and gold ores
The drop rate is applied in the box in the mine!
I'm using this mode so well
Thank you for your kind help!
at UpdateOreGemDropsPatch.ModifiedOnStoneDestroyed(String stoneId, Int32 x, Int32 y, Farmer who) in C:\Users\jesse\source\repos\MineforMore\Patches\UpdateOreGemDropsPatch.cs:line 267
at StardewValley.GameLocation.OnStoneDestroyed_PatchedBy<DaLion.Professions__Darkmushu.MineForMore__spacechase0.SpaceCore>(GameLocation this, String stoneId, Int32 x, Int32 y, Farmer who)
at StardewValley.GameLocation.destroyObject(Vector2 tileLocation, Boolean hardDestroy, Farmer who)
at StardewValley.Monsters.DustSpirit.behaviorAtGameTick_PatchedBy<DaLion.Professions>(DustSpirit this, GameTime time)
at StardewValley.Monsters.Monster.update_PatchedBy<DaLion.Core__DaLion.Professions__PeacefulEnd.AlternativeTextures>(Monster this, GameTime time, GameLocation location)
at StardewValley.GameLocation.updateCharacters(GameTime time)
at StardewValley.GameLocation.updateEvenIfFarmerIsntHere_PatchedBy<DaLion.Core__prism99.aedenthorn.FarmAnimalHarvestHelper>(GameLocation this, GameTime time, Boolean ignoreWasUpdatedFlush)
at StardewValley.Locations.MineShaft.updateEvenIfFarmerIsntHere(GameTime time, Boolean ignoreWasUpdatedFlush)
at StardewValley.Locations.MineShaft.UpdateMines(GameTime time)
at StardewValley.Game1.UpdateLocations_PatchedBy<spacechase0.SpaceCore>(Game1 this, GameTime time)
at StardewValley.Game1._update_PatchedBy<Nature.NatureInTheValley>(Game1 this, GameTime gameTime)
at StardewValley.Game1.Update(GameTime gameTime)
at StardewModdingAPI.Framework.SCore.OnPlayerInstanceUpdating(SGame instance, GameTime gameTime, Action runUpdate)
What kind of mistake is that?
Edit **
Bug resolved.
the other patch error with spacecore and delion im not sure on
The mod does allow you to control the gem drop and ore drop count so you can just get more gems to sell to make up the difference. The blacksmith profession if learned also grant instant smelting as a recipe for more resource cost but if you change the ore drop in config file this shouldn't really affect the end results
it would be cool if you could use the mod only to make mining bufffood useful
See formula below.
Number is the amount of stone that would drop when you break a stone,
MinerProfessionBonusOrePerLevel is 0 if you don't have mining profession or calculates amount per level.
Formula:
Number = (int)((Number + MinerProfessionBonusOrePerLevel + Instance.Config.AddStone) * Instance.Config.MultiplyStone).
I would recommend turning off "TurnOnMaxLevelFrom10toUnlimited" my setting to see if that helps in case it messes with the other exp system. Or trying my previous version v1.0.2 which doesn't apply any profession checks and had simpler formula to drop ore.
this seems to be caused by the spacecore luck skill mod
this compatible with the Vanilla Plus Professions mod right??
just wondering :3
For concerns on profession the other mod describes their mod as custom which I'm assuming they might add new profession ID. I actually don't add Id for my profession, I just check the vanilla professional ID is learn then apply my own mod logic and so I don't anticipate any compatibility issues here.
Some area where there might be compatability issues is that the other mod has a skill called upheaval which changes all nodes to a geode . I run a code to change nodes to a geode , gem or coal node as well and although both our set of code would run with various order, only 1 return value would be passed back into the game. If my code runs last my node is passed back and is created in the mine,, if their code is ran their nodes will be passed back and created in the mine. The game will run but the nodes generated will depend on which code is ran last.
"I've downloaded it, but I'm unsure how to use it. The stones in the mine still drop as they normally do when I mine them."
Once you've installed this mod and SMAPI, it should automatically work.
This mod does not work on all stones, only the stones that normally would drop more than 1 stone at a time.
You can see the video In this mod to see that not all stone nodes dropped many stones only certain one drops it. I hope this helps.