For anyone checking their mods for a massive fps drop when scanning devices, this is the problem. With some mods, the logic doesn't work very well. Just go back to 0.0.0.2 versions, and everything will work flawlessly.
I fixed the compatibility of this mod in ver 0.0.0.3 so that other mods that wrap(handle) the same function now work. If you experience fps drops in ver 0.0.0.3, I think this is because the processing of other mods that did not work in ver 0.0.0.2 now works in ver 0.0.0.3. This means that the FPS drop is most likely caused by other mods that are wrapping(handling) the same function.
This wasn't at the top of my list of annoyances in my original playthrough, but it wasn't far. I'm glad someone figured out a way to fix this since the devs didn't. Thank you!
which makes our mod quite incompatible, since yours would overwrite my changes My function already returns wrapped method, if player is not using my new cyberware, and think the only way to make it work together, if the change would be made in your code. (maybe call wrapped method, and than sort the quickhack array returned by it?).
Would it be possible for you to update it to make our mods compatible?
Would it be possible for you to update it to make our mods compatible?
Sorry, I can't. This mod needs to replace(cant call wrappedMethod) GetPlayerQuickHackListWithQuality because it requires "let parts: array<SPartSlots>" in all cases. Therefore, unless you load it after my mod, any changes you make to GetPlayerQuickHackListWithQuality will be overwritten by my mod. I think the only solution is to change the load order of the mods.
Alphabetical *.reds load order: - r6\scripts\BlackChrome\CyberdeckSupport.reds (yours) Wrap GetPlayerQuickHackListWithQuality(yours). - r6\scripts\quickhacks_sort_by_slot\quickhacks_sort_by_slot.reds (mine) Replace GetPlayerQuickHackListWithQuality(mine). Your GetPlayerQuickHackListWithQuality(yours) is removed.
Can you wrap GetPlayerQuickHackListWithQuality in your mod after my mod? For example, create r6\scripts\zzz_BlackChrome\compat.reds and redefine GetPlayerQuickHackListWithQuality in compat.reds. Alphabetical load order: - r6\scripts\BlackChrome\CyberdeckSupport.reds (yours) Wrap GetPlayerQuickHackListWithQuality(yours). - r6\scripts\quickhacks_sort_by_slot\quickhacks_sort_by_slot.reds (mine) Replace GetPlayerQuickHackListWithQuality(mine). Your GetPlayerQuickHackListWithQuality(yours) is removed. - r6\scripts\zzz_BlackChrome\compat.reds (new) Rewrap GetPlayerQuickHackListWithQuality(yours).
Then, how about distributing zzz_BlackChrome\compat.reds as a misc file?
I think it would work if you just changed r6\scripts\BlackChrome to r6\scripts\zzz_BlackChrome, but the file path is messed up. Or, I think it will work if I change r6\scripts\quickhacks_sort_by_slot to r6\scripts\___quickhacks_sort_by_slot so that it is loaded before BlackChrome. But I don't want to change the path because this mod have a lot of users.
Oh, didn't know that I could change load order this way. Thanks for reply :D Gonna try to update my script file path and see if it works.
Just one question: 'But I don't want to change the path because this mod have a lot of users.' - about this one. Just curious why is this a problem. Still a bit new to modding. Does changing script file, might mess it for the end users if they download the update?
I am concerned that users who manually install this mod may not delete the old version and both paths may remain. I also don't know if ModManager will delete the old version correctly. And I was worried about the inquiry that I uninstalled this MOD but it is not restored. If it's in development, I feel free to make changes and support with comments, but this mod is no longer in development. (This is not a complicated mod that requires any development.)
I think the author of redscript intends to eventually add a check during compilation to report exactly this, he just has bigger fish to fry.
The only reason I found it is that I wrote a tool for personal use (I might release it, I dunno) that parses all redscripts for mods I have installed and does the check. I just happened to have this mod and Sort Device Vehicle Quickhacks enabled in MO2 when I ran it. And happy to help!
Wish this mod allowed you to download it. Seems like a cool mod to have not sure why the author seems to have it locked in a "you need redscript" loop for no apparent reason
This mod works fine, except I think (RPGManager) GetPlayerQuickHackListWithQuality(player:wref<PlayerPuppet>)->array<PlayerQuickhackData> should use replaceMethod.
Woohoo, still working as advertised, with the recent/new game Patch 2.2 update, hella nice! \o/ ♥
noborudesu 11 December 2024, 6:22AM works for me on 2.2. uninstall other unrequirement mods.
THANK YOU for the 2.2 confirmation, noborudesu!! o7
And THANK YOU for this hella preem and frickin' essential mod, and it's past year+ of max nova service!!
Still appreciatin' ya, choombatta!! ♥ :)
Spoiler:
Show
Patch 2.2
Vanilla - Quickhacks arrangement in Inventory/Cyberware Slots screen.
Vanilla - Quickhacks in Scanner HUD arrangement NOT congruent with Inventory/Cyberware Slots screen arrangement.
Mod Enabled - Quickhacks in Scanner HUD arrangement are now consistent with Inventory/Cyberware Slots screen arrangement. Mod is still working as advertised, with the recent/new game Patch 2.2 update. Hella nice.
128 comments
-
1
-
2
-
3
- ...
-
8
-
JumpStill one of my all time fav and must have essential mods!! \o/ ♥
Installed
Inventory/Cyberware
Quickhacks slot placements.
Vanilla
Scanner View - Quickhacks arrangement is not consistent with actual Inventory/Cyberware Quickhacks slot placements.
Modded
Scanner View - Quickhacks arrangement is now accurate/identical to actual Inventory/Cyberware Quickhacks slot placements.
In-game, Save loaded
Modded
Frickin' LOVE this mod, hhnngg!! :D ♥
If you experience fps drops in ver 0.0.0.3, I think this is because the processing of other mods that did not work in ver 0.0.0.2 now works in ver 0.0.0.3. This means that the FPS drop is most likely caused by other mods that are wrapping(handling) the same function.
Some time ago, I made a mod that adds new cyberware :https://www.nexusmods.com/cyberpunk2077/mods/16031
One of new cyberware, is using wrapped function:
GetPlayerQuickHackListWithQuality
which makes our mod quite incompatible, since yours would overwrite my changes My function already returns wrapped method, if player is not using my new cyberware, and think the only way to make it work together, if the change would be made in your code. (maybe call wrapped method, and than sort the quickhack array returned by it?).
Would it be possible for you to update it to make our mods compatible?
This mod needs to replace(cant call wrappedMethod) GetPlayerQuickHackListWithQuality because it requires "let parts: array<SPartSlots>" in all cases.
Therefore, unless you load it after my mod, any changes you make to GetPlayerQuickHackListWithQuality will be overwritten by my mod.
I think the only solution is to change the load order of the mods.
Alphabetical *.reds load order:
- r6\scripts\BlackChrome\CyberdeckSupport.reds (yours)
Wrap GetPlayerQuickHackListWithQuality(yours).
- r6\scripts\quickhacks_sort_by_slot\quickhacks_sort_by_slot.reds (mine)
Replace GetPlayerQuickHackListWithQuality(mine).
Your GetPlayerQuickHackListWithQuality(yours) is removed.
Can you wrap GetPlayerQuickHackListWithQuality in your mod after my mod?
For example, create r6\scripts\zzz_BlackChrome\compat.reds and redefine GetPlayerQuickHackListWithQuality in compat.reds.
Alphabetical load order:
- r6\scripts\BlackChrome\CyberdeckSupport.reds (yours)
Wrap GetPlayerQuickHackListWithQuality(yours).
- r6\scripts\quickhacks_sort_by_slot\quickhacks_sort_by_slot.reds (mine)
Replace GetPlayerQuickHackListWithQuality(mine).
Your GetPlayerQuickHackListWithQuality(yours) is removed.
- r6\scripts\zzz_BlackChrome\compat.reds (new)
Rewrap GetPlayerQuickHackListWithQuality(yours).
Then, how about distributing zzz_BlackChrome\compat.reds as a misc file?
I think it would work if you just changed r6\scripts\BlackChrome to r6\scripts\zzz_BlackChrome, but the file path is messed up.
Or, I think it will work if I change r6\scripts\quickhacks_sort_by_slot to r6\scripts\___quickhacks_sort_by_slot so that it is loaded before BlackChrome. But I don't want to change the path because this mod have a lot of users.
Gonna try to update my script file path and see if it works.
Just one question:
'But I don't want to change the path because this mod have a lot of users.' - about this one. Just curious why is this a problem. Still a bit new to modding. Does changing script file, might mess it for the end users if they download the update?
I also don't know if ModManager will delete the old version correctly.
And I was worried about the inquiry that I uninstalled this MOD but it is not restored.
If it's in development, I feel free to make changes and support with comments, but this mod is no longer in development.
(This is not a complicated mod that requires any development.)
(RPGManager) GetPlayerQuickHackListWithQuality(player:wref<PlayerPuppet>)->array<PlayerQuickhackData>
in r6\scripts\quickhacks_sort_by_slot\quickhacks_sort_by_slot.reds ( line# 58 )
As is, it's probably causing a silent conflict with other mods that wrap that function -- like Sort Device Vehicle Quickhacks.
https://wiki.redmodding.org/redscript/language/language-features/annotations#replacemethod-class
The only reason I found it is that I wrote a tool for personal use (I might release it, I dunno) that parses all redscripts for mods I have installed and does the check. I just happened to have this mod and Sort Device Vehicle Quickhacks enabled in MO2 when I ran it. And happy to help!
And THANK YOU for this hella preem and frickin' essential mod, and it's past year+ of max nova service!!
Still appreciatin' ya, choombatta!! ♥ :)
Vanilla - Quickhacks arrangement in Inventory/Cyberware Slots screen.
Vanilla - Quickhacks in Scanner HUD arrangement NOT congruent with Inventory/Cyberware Slots screen arrangement.
Mod Enabled - Quickhacks in Scanner HUD arrangement are now consistent with Inventory/Cyberware Slots screen arrangement.
Mod is still working as advertised, with the recent/new game Patch 2.2 update. Hella nice.
-
1
-
2
-
3
- ...
-
8
-
Jump