0 of 0
File information
Created by
keanuWheeze and scornthegreatUploaded by
NexusGuy999Virus scan
Safe to use
Notifications
641 comments
https://www.nexusmods.com/cyberpunk2077/mods/20668?tab=description
Cool mod!
EDIT: Oh yeah, almost certainly something was broken. I think most of the stock volatility (and thus profit potential) was from the entire market reinitializing quite often. Just checked out the console (for a different mod) and I'm getting repeated bursts of 'StockMarket OverflowReset'. I went through a few of the market persistence .lua files, and the only number that stood out as strange in them was an infinitesimal for Tsunami's "spent", something like -9e-9, along with one having a tsunamiAction of -3e-18.
Edit 2: I got bored and remembered CET mods are uncompiled lua scripts, so I decided to dig in and find the issue. getStockDelta() is returning ridiculous values for some stocks due to stockInvest (varying, I've seen over 2000) and moneySpent (around 1500 at all times). This makes the stocks go way over their maximum, causes an overflow, and resets the market.
Additionally, moneySpent seems to push the stocks affected by it up in value constantly, and the trigger doesn't decay. I played with the stock market for... a while... and have spent ludicrous amounts of money - hence a 1500 moneySpent trigger. By now these stocks overflow whenever they try to update. I decided to remove the effects of the triggers.
In modules/logic/triggerManager.lua, I changed
for _, trigger in pairs(stock.triggers) do
todelta = delta + self.triggers[trigger.name].exportData.value * trigger.amount
end
for _, trigger in pairs(stock.triggers) do
local triggerValue = self.triggers[trigger.name].exportData.value * trigger.amount
if trigger.name == "moneySpent" or trigger.name == "stockInvest" then
triggerValue = 0
end
delta = delta + triggerValue
end
Since applying this change, I have not had a single market reset in multiple hours.
The market design includes minimum and maximum values any given stock can be worth. If a stock is out of this range after it updates, the entire stock market is reset. Resetting the market randomizes the values of all stocks (within a certain range for each). I keep the stocks I have in my portfolio when the market resets. If resets happen frequently, this totally breaks the concept of a stock market that you either have to manipulate or wait a long time for returns, and basically turns it into a free slot machine. Just buy when it randomly plummets in price and then wait for RNG to give you a good number. It meant that I could make money WAY faster than intended, sometimes up to 20% growth within literally a minute.
One of the reasons the stocks go up or down is because, on each update of the market, various 'triggers' influence the stock value. These triggers are how things like the state of various quests, police/civilian massacres and player weapon usage effect the stock market. The triggers are directly added to the stock's value in each update. Most of the triggers are scaled right and have pretty small values, so their effect is minor compared to the random movements of the stock - usually just enough to influence the general trend slightly. Unfortunately, there are two triggers that don't seem to quite work right: 'moneySpent' and 'stockInvest'.
I believe moneySpent is literally based on the sum total of all money you have spent on a character. Maybe 1/10,000 or 1/100,000 of the total you've spent? A cubic root? Not sure. The problem is that I didn't see any type of decay. I have a character with 45h of playtime and the moneySpent has reached 1500, while most of the stocks have a max of a few hundred. Whenever the market tried to update a stock that uses this trigger, the stock would go way over it's maximum and cause a market reset. Even at far lower values, this would cause infrequent resets because the stocks always went up.
I'm not sure what stockInvest is based on. I assume based on the name that how much you invest in the stock and how much it's worth have something to do with it, althought it might just be the sheer quantity of stock units bought/sold. I've purchased about 5 million worth of a stock and the next update had a 2000 stockInvest trigger added, which caused a market reset, and it was 0 the rest of the time as long as I bothered to check out. (Also, I feel like the stock price of any megacorporation worth the title shouldn't even twitch at 100 million of private equity investing or divesting.)
I was a few hours into debugging and didn't want to dig even deeper to figure out how these values were set, so I made a quick and simple fix. When the list of triggers is being processed, instead of just adding each trigger blindly, check if the name of the trigger is moneySpent or stockInvest; if it is one of them, add 0 instead of the actual value. This removes the effects of only these two triggers, leaving the stock market otherwise unchanged - still easily manipulatable via massacres and weapon usage, still totally OP in terms of profit potential, just not literally broken.
function triggerManager:getStockDelta(stock) -- Apply triggers
local delta = 0
local triggerValue = 0
for _, trigger in pairs(stock.triggers) do
if trigger.name == "moneySpent" or trigger.name == "stockInvest" then
triggerValue = 0
else
triggerValue = self.triggers[trigger.name].exportData.value * trigger.amount
end
end
delta = delta + triggerValue -- Buy sell trigger
return delta
end
This code goes in Cyberpunk 2077\bin\x64\plugins\cyber_engine_tweaks\mods\stocks\modules\logic\triggerManager.lua on lines 45-59. It seems to work on my end, as I can still access the Stock Market tab and use it fully, but YMMV.
I opened the triggerManager.lua file and after copying and pasting your choice of code, I noticed that the "function" at the start didn't turn orange like all the other ones in the file, and also, the collapsible (+-) icon was not next to it either, so the line didn't extend till the 'end' of the function. I tried to re-paste it, to no effect. Tried to backspace and space, but that didn't do anything either. So i just copy pasted the 'function' in the code above and deleted the non-responsive one. Since I'm not sure if others will understand the way I've explained it, I'll attach some images for easy reference. Now when I open the game, the stock market tab is present.
Edit: I'm using Notepad++. I'm not sure if all these code coloring and collapsability comes with regular notepad.
1) After copying the code. Notice the 'function' at the start is not orange like the one at the bottom.
2) Copy paste a 'function' from another part of the file.
3) Now delete the non-responsive function, so that the code looks like this.
4) PROFIT!!!
https://pastebin.com/AjtxJJKS
Note: It's more balanced than before and it's not broken (on "overflow" the market WILL recover pretty quickly -- there is no longer a fail state), but it's certainly not balanced because it's way too difficult for the player to actually lose money. It would take significant effort to truly balance this... off the top of my head right now:
1) prevent player from selling or buying however many shares they want at whatever the current share price is.
2) before large market moves up or down, individual stocks should (usually) go nearly perfectly sideways for at least some period of time until "something happens" in the world.
I would pay good money for this to be fixed and expanded with options/futures and some quests.
After disabling Stock Market and News System, mods for the virtual atelier and virtual car dealer are working again
Not by me
occasionally the stock price will crash and the console is filled with "[StockMarket] OverflowReset initiated: If you want to help debug this, pause the game, then take the newest file from the "Cyberpunk 2077\bin\x64\plugins\cyber_engine_tweaks\mods\stocksdata\persistent" and send it to me on Nexus (Ideally a direct message)"
SSystem = Game.GetSettingsSystem() hud = SSystem:GetGroup('/interface/hud') new = not hud:GetVar('healthbar'):GetValue() for _, var in ipairs(hud:GetVars(false)) do var:SetValue(new) end if hud:GetVar('healthbar'):GetValue() == false and Game.GetQuestsSystem():GetFactStr("q000_var_arasaka_ui_on") == 0 then print(" - ARASAKA HUD: ON") Game.GetQuestsSystem():SetFactStr("q000_var_arasaka_ui_on", 1) else print(" - ARASAKA HUD: OFF") Game.GetQuestsSystem():SetFactStr("q000_var_arasaka_ui_on", 0) end
So far the stock system doesn't seem to affect it, and I see a few placeholder stock texts, but for now it's fine for me for extra immersion.