I downloaded and opened your original mod from here, deleted all of the text, and just filled it with the text from the link you gave us : https://pastebin.com/bnGB02RE And yes, I also installed the prerequisite mods which are redscript and Cybercmd(standalone version). Any ideas?
Sorry for all these messages, but .. it seems to just work sometimes. Like I just wiped out a group with contagion, and I wasn't getting traced at all. Weird...
Eine Frage an die welche die Spiele version 2.12a nutzten. Welche Anpassung habt ihr vorgenommen damit diese mod wieder geht? Oder welche nutzt ihr jetzt?
A question for those who used the games version 2.12a. What adjustments did you make so that this mod works again? Or which one are you using now?
This Mod seems to conflict with the Stealthrunner mod https://www.nexusmods.com/cyberpunk2077/mods/7616 and part of the game, once installed i don't get NCPD crime notifications anymore!:/
Fixed the error by simply rewriting the whole ting to this
@wrapMethod(NPCPuppet) public final static func RevealPlayerPositionIfNeeded(ownerPuppet: wref, playerID: EntityID, opt isPrevention: Bool) -> Bool { let characterRecord: ref = TweakDBInterface.GetCharacterRecord(ownerPuppet.GetRecordID()); let archetypeName: gamedataArchetypeType = characterRecord.ArchetypeData().Type().Type(); let isNetrunner: Bool = ArrayContains( [gamedataArchetypeType.NetrunnerT1, gamedataArchetypeType.NetrunnerT2, gamedataArchetypeType.NetrunnerT3],archetypeName); if isNetrunner { wrappedMethod(ownerPuppet,playerID,isPrevention); } else { return false; } }
This a a wrap instead of a replace It moves the isNetrunner check out of the normal function and the evt problem can be handled by the normal ingame function IF it is a netrunner
no i actually did do that, i had an unedited version of this file side by side and copied the line formats so i did have it the way you typed it in one line, but didnt work, gave that error message i wrote - perhaps you can post an imgur link so i can see how you pasted it all and ill copy that, can you also tell how many spaces each line has?
to be clear this wrap you wrote down means that itll fix this mod, and at the same time not give anymore redscript error messages every time the game launches? because there was a comment here that said removing:
let evt: ref<HackPlayerEvent>; let hackingMinigameBB: ref<IBlackboard>;
would make it work and it did, only it still gave redscript error messages every launch but it still worked, however this mod https://www.nexusmods.com/cyberpunk2077/mods/9306 (which is the same as this only that one prevents all enemies and not just netrunners from being able to track you) does work and also doesnt give redscript errors at launch
I take no credit for this code, just posting the code that TheHoss2 provided above as an image, I have NOT tested if this code works, I can confirm that it compiles properly as per redscript_rCURRENT.log and gets me to the main menu
To anyone reading this, there is a way to get this to work, I found the workaround by reading a comment by helly111 from the Disable Reveal Position Hack - All Enemies version:
Open the script with a text editor and delete the 2 following lines:
let evt: ref<HackPlayerEvent>; let hackingMinigameBB: ref<IBlackboard>;
Save the file and launch the game.
This works for both that version and this version, but NOTE that even if you do this, YOU WILL STILL GET AN ERROR MESSAGE when starting up the game, nonetheless it will still work. This error message only shows up on this version and not the All Enemies version for some reason.
If you want specifics, what I did was only highlight the lines needed to be deleted, I highlighted them one line at a time, and deleted with the delete button and not backspace if that helps, maybe not but hey whatever works works right?
im sorry, but theres clearly something that you've done wrong yourself, because im playing from the start and right now im with jackie trying to get back sandra dorsett and im in the point where were hiding in a corner waiting for 2 scavs to come out so we can stealth kill/ko them and when they both came out and went to their spots, i hit one with overheat, then waited 2 seconds and applied short circuit to the other - no tracing, works absolutely fine
perhaps you havent updated your core mods, or maybe you accidentally deleted a letter in the notepad, simply something on your end is what im trying to get at
in fact, i will go ahead and record my screen from desktop, showing i have the updated core mods + this mod with the edited file then launch game and show that tracing is removed, give me a few minutes to record and upload
- okay, recorded, i didnt know you couldnt see my mouse cursor but do take note of the version of the game and mods - all updated, and the lines i deleted from the notepad
The downloaded file from this mod and a grab of yours from the video is here: https://imgur.com/a/m80VRCi - Notice the two lines to be removed are at the top just under the 'public' statement - I re-downloaded the mod to make this image, just to be sure I was using the proper source - Your file has way more removed than just those two lines
I'm going to change my file to match yours, and your version honestly makes sense because it looks like you've also removed anything using the evt variable that's creation was a removed line, as well as anything referencing the hackingMinigameBB and IBlackboard variables.
EDIT: I wanted to add, thank you for showing the version of the file you're using as that's probably key to figuring out why mine is borked and yours isn't
EDIT 2: All right, using your version of the script seems to work fine - I don't even get the script error at startup which is a nice QoL. I have no explanation why your script is so short comparatively, but it's working so I'm good. Thanks for posting your version for comparison, probably wouldn't have figured this out without it.
actually, i made a mistake in that video, the part in the video where i made a comparison with the two notepads, is actually the file from the other mod version of this that im using which is disables tracking for all enemies because when i used that with the 2 lines removed, it didnt even show any error at startup
that version actually has less lines compared to this version which is why its shorter, but do take note that for this version, even if you remove the two lines, it will still remove the tracing in the game but you will still get an error message at startup, as to if it makes enemy netrunners able to track you if you hack them... i havent gone too far into the game to try but needless to say this version really does need an update for that script error everytime it launches problem
so for now because i dont want to keep getting that annoying startup error im using that version until a fix is updated here
While this mod does work by deleting the two lines in notepad, it really does need an update because it shows redscript errors, the tracing indeed is removed but its annoying to have a redscript error notification everytime the game is launched
73 comments
https://pastebin.com/bnGB02RE
Has it suddenly stopped working for you guys?
All I did was install a mod to skip the intro logos when you load up Cyberpunk
I downloaded and opened your original mod from here, deleted all of the text, and just filled it with the text from the link you gave us :
https://pastebin.com/bnGB02RE
And yes, I also installed the prerequisite mods which are redscript and Cybercmd(standalone version).
Any ideas?
Weird...
When you got traced, did you check if there was a netrunner nearby?
Welche Anpassung habt ihr vorgenommen damit diese mod wieder geht?
Oder welche nutzt ihr jetzt?
A question for those who used the games version 2.12a.
What adjustments did you make so that this mod works again?
Or which one are you using now?
@wrapMethod(NPCPuppet)
public final static func RevealPlayerPositionIfNeeded(ownerPuppet:
wref, playerID: EntityID, opt isPrevention: Bool)
-> Bool {
let characterRecord: ref = TweakDBInterface.GetCharacterRecord(ownerPuppet.GetRecordID());
let archetypeName: gamedataArchetypeType = characterRecord.ArchetypeData().Type().Type();
let isNetrunner: Bool = ArrayContains(
[gamedataArchetypeType.NetrunnerT1, gamedataArchetypeType.NetrunnerT2, gamedataArchetypeType.NetrunnerT3],archetypeName);
if isNetrunner {
wrappedMethod(ownerPuppet,playerID,isPrevention);
}
else
{
return false;
}
}
This a a wrap instead of a replace
It moves the isNetrunner check out of the normal function and the evt
problem can be handled by the normal ingame function IF it is a
netrunner
method RevealPlayerPositionIfNeeded not found on NPCPuppet
Thats the second line
public final static func RevealPlayerPositionIfNeeded
(ownerPuppet: wref, playerID: EntityID, opt isPrevention: Bool) -> Bool {
Its probably a safety feature. You're not really supposed tp post mods as text here.
to be clear this wrap you wrote down means that itll fix this mod, and at the same time not give anymore redscript error messages every time the game launches? because there was a comment here that said removing:
let evt: ref<HackPlayerEvent>;
let hackingMinigameBB: ref<IBlackboard>;
would make it work and it did, only it still gave redscript error messages every launch but it still worked, however this mod https://www.nexusmods.com/cyberpunk2077/mods/9306 (which is the same as this only that one prevents all enemies and not just netrunners from being able to track you) does work and also doesnt give redscript errors at launch
It has to be
...wref[ScriptedPuppet], player ID...
but with angle brackets instead of square brackets
https://staticdelivery.nexusmods.com/images/3333/417517-1702115445.png
edit: can confirm the code works fine, also pastebin:
https://pastebin.com/nCYwgPFY
Open the script with a text editor and delete the 2 following lines:
let evt: ref<HackPlayerEvent>;
let hackingMinigameBB: ref<IBlackboard>;
Save the file and launch the game.
This works for both that version and this version, but NOTE that even if you do this, YOU WILL STILL GET AN ERROR MESSAGE when starting up the game, nonetheless it will still work. This error message only shows up on this version and not the All Enemies version for some reason.
If you want specifics, what I did was only highlight the lines needed to be deleted, I highlighted them one line at a time, and deleted with the delete button and not backspace if that helps, maybe not but hey whatever works works right?
Taking on random groups of mobs with no netrunners and still getting located as soon as I drop a quick hack on them
perhaps you havent updated your core mods, or maybe you accidentally deleted a letter in the notepad, simply something on your end is what im trying to get at
- okay, recorded, i didnt know you couldnt see my mouse cursor but do take note of the version of the game and mods - all updated, and the lines i deleted from the notepad
https://www.youtube.com/watch?v=0QdQS_Zgef0
The downloaded file from this mod and a grab of yours from the video is here: https://imgur.com/a/m80VRCi
- Notice the two lines to be removed are at the top just under the 'public' statement
- I re-downloaded the mod to make this image, just to be sure I was using the proper source
- Your file has way more removed than just those two lines
I'm going to change my file to match yours, and your version honestly makes sense because it looks like you've also removed anything using the evt variable that's creation was a removed line, as well as anything referencing the hackingMinigameBB and IBlackboard variables.
EDIT: I wanted to add, thank you for showing the version of the file you're using as that's probably key to figuring out why mine is borked and yours isn't
EDIT 2: All right, using your version of the script seems to work fine - I don't even get the script error at startup which is a nice QoL. I have no explanation why your script is so short comparatively, but it's working so I'm good. Thanks for posting your version for comparison, probably wouldn't have figured this out without it.
that version actually has less lines compared to this version which is why its shorter, but do take note that for this version, even if you remove the two lines, it will still remove the tracing in the game but you will still get an error message at startup, as to if it makes enemy netrunners able to track you if you hack them... i havent gone too far into the game to try but needless to say this version really does need an update for that script error everytime it launches problem
so for now because i dont want to keep getting that annoying startup error im using that version until a fix is updated here