Very nice mod, thank you! I found some issues in some recipes, fix it please if it is.
Cube Recipes - Upgrade - "Normal Rare Armor Ral+*8THul Rune Perfect Amethyst" - doesnt work font here and name of thule i guess. All others names etc works for me as intended i mean, just not this one.
Cube Recipes - Reroll - "Magic Weapon Chpped Gem x 3" shall be "Magic Weapon Chipped Gem x 3" i guess.
Cube Recipes - Reroll - "Socketed Weapon Standard Gems x 3" shall be "Magic Weapon Standard Gems x 3" i think, same as other stages of this craft by using other gems for getting another ivlvs i mean.
Cube Recipes - Crafting - Safety Type - Amulet and Ring - wrong names of runes (when u mouseover them) instead of right pictures of runes - it shows Thul rune with name Ral (shall be "Thul") on amulet and it shows Amn rune with name Thul (shall be "Amn") on a ring.
If i reported something wrong, my bad, just wanted to help. Thank you again for your mod.
addon, overwrites ui.json, that another mod above (in install order) has edited. Maybe you mod doesn't check if file is extracted and forces re-extracting it? (or maybe it is D2RMM fault)
Item Dictionary mod does not overwrite ui.json. It just adds new strings with getNextStringID function. But if another mod above add string with fixed id at ui.json, this may cause conflict.
i edited "ui.json", got rid of those "squares" - didn't help then edited again, deleted all your new IDs (all your added rows, so file now has same amount of rows, as original) - it has helped. In game everything except Dictionary has proper strings. In Dictionary descriptions instead of "missing strings" it says literally same, but in russian language ("missing string" phrase localized in another language). Im not good at parsing to check it by myself, but maybe in the next update you all missing localization enries, but with the strings same, as English in the " " values? So those values will not be empty, they just will be english for all localizations (Key value will be same as in english variant). And maybe sort it as well, so enUS is first, all other languages in same order, as original IDs do.
I like this mod, but i have to report a bug, your mod somehow breaks russian localization strings. I tried installing your mod even as a single mod. When i run russian localization, it shows "missing string" (even in the main menu, on every button, first occurence, when the game starts-up, at logo instead of "Press any key to begin" it says "missing string", then in the character selection screen every buttons has same text. It also same all white texts of item tooltips (on level 1 character, who has only white items). The only case, where it properly displays something - is the item name (even in Dictionary panels), every or most (maybe 80-90% of other text strings are "missing string". When i switch game to english localization - it works as intended.
I compared original extracted "ui.json" file to your modded file using WinMerge software, but i still couldn't find a source of problem (except, some "squares" (symbols) in middle of file, in particular, in various languages, of 26347, 26348, and 26349 (just these 3, that's all). But english in those ID is also with that square, so i dont think, it is related).
Btw, in english localization, it has some korean text on the description of Set helm of Immortal King, left side of dictionary (IK set is in the expansion tab)
28 comments
I found some issues in some recipes, fix it please if it is.
- Cube Recipes - Upgrade - "Normal Rare Armor Ral+*8THul Rune Perfect Amethyst" - doesnt work font here and name of thule i guess. All others names etc works for me as intended i mean, just not this one.
- Cube Recipes - Reroll - "Magic Weapon Chpped Gem x 3" shall be "Magic Weapon Chipped Gem x 3" i guess.
- Cube Recipes - Reroll - "Socketed Weapon Standard Gems x 3" shall be "Magic Weapon Standard Gems x 3" i think, same as other stages of this craft by using other gems for getting another ivlvs i mean.
- Cube Recipes - Crafting - Safety Type - Amulet and Ring - wrong names of runes (when u mouseover them) instead of right pictures of runes - it shows Thul rune with name Ral (shall be "Thul") on amulet and it shows Amn rune with name Thul (shall be "Amn") on a ring.
If i reported something wrong, my bad, just wanted to help.Thank you again for your mod.
addon, overwrites ui.json, that another mod above (in install order) has edited. Maybe you mod doesn't check if file is extracted and forces re-extracting it?
(or maybe it is D2RMM fault)
then edited again, deleted all your new IDs (all your added rows, so file now has same amount of rows, as original) - it has helped.
In game everything except Dictionary has proper strings.
In Dictionary descriptions instead of "missing strings" it says literally same, but in russian language ("missing string" phrase localized in another language). Im not good at parsing to check it by myself, but maybe in the next update you all missing localization enries, but with the strings same, as English in the " " values? So those values will not be empty, they just will be english for all localizations (Key value will be same as in english variant). And maybe sort it as well, so enUS is first, all other languages in same order, as original IDs do.
I compared original extracted "ui.json" file to your modded file using WinMerge software, but i still couldn't find a source of problem (except, some "squares" (symbols) in middle of file, in particular, in various languages, of 26347, 26348, and 26349 (just these 3, that's all). But english in those ID is also with that square, so i dont think, it is related).
Btw, in english localization, it has some korean text on the description of Set helm of Immortal King, left side of dictionary (IK set is in the expansion tab)