After two months of illness, I am back in the community and plan to update all my mods for the Hildir's Request. As of now I have tested most of the mods and they are all working both in the current and public test branches. That being said I will rebuild them with the new game files once available.
Let me know if you have any issues and thanks again for using my mods.
There's a conflict between this mod and Airshipplus. Is there anything that can be configured/edited with this mod so it doesn't break airshipplus? I'd like to use both if possible.
When No Smoke Stay Lit is installed, it breaks airships (they show no fuel), according to airships dev, it's a problem with how No Smoke edits fire sources, and their solution is to uninstalled No Smoke to fix it. I'm getting this error in my console, not sure if related:
[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object Stack trace: NoSmokeStayLit.Patches.FireplaceIsBurning_Patch.Postfix (Fireplace __instance, System.Boolean& __result, UnityEngine.GameObject& ___m_enabledObjectHigh, ZNetView& ___m_nview) (at <8bc0da42d5ff4d39aa8d95d9b9b51961>:0) (wrapper dynamic-method) Fireplace.DMD<Fireplace::IsBurning>(Fireplace) (wrapper dynamic-method) Fireplace.DMD<Fireplace::UpdateFireplace>(Fireplace)
Yea, I mean this is a classic example of mod incompatibility. He uses the flames to fuel the ship. I tell the game to turn off the flames and take away the smoke. I am looking at his code and we both edit the Awake method.
[HarmonyPatch(typeof(Fireplace), "Awake")]
These are just not going to work together. If you are just looking to take away the smoke, maybe you can use my No Smoke Simplified mod
Reporting that the "keep fueled" option for stone ovens appears to be non-functional as of the May 20th update to the mod. EDIT: Disregard about the ovens. Deconstructing and reconstructing them appears to have fixed this issue. It also does not appear that there is support for either the firepit purchased from Hildir, or the blue flame standing brazier.
NullReferenceException: Object reference not set to an instance of an object at NoSmokeStayLit.Patches.KeepFueledPatch+Fireplace_UpdateFireplace_Patch.Fireplace_UpdateFireplace (Fireplace __instance, ZNetView& ___m_nview) [0x00014] in <c064c06613fd42688146a60faa5b49c1>:0 at (wrapper dynamic-method) Fireplace.DMD<Fireplace::UpdateFireplace>(Fireplace)
Love the mod just found a couple of sources that don't seem to be staying lit, there original variant Standing Brazier works fine. - Blue Standing Brazier - Firepit Iron
We love using your mod to keep vanilla look while not being slaves to refilling our base lights. The bonus is removing it doesn't remove the lights, unlike modded/replacement lights.
I don't know if it's from the (very) recent update, or a new interaction, but this mod no longer works for me, throwing lots of: MissingMethodException: Method not found: UnityEngine.Transform .Utils.FindChild(UnityEngine.Transform,string) at (wrapper dynamic-method) Fireplace.DMD<Fireplace::IsBurning>(Fireplace) at (wrapper dynamic-method) Fireplace.DMD<Fireplace::UpdateFireplace>(Fireplace) and MissingMethodException: Method not found: UnityEngine.Transform .Utils.FindChild(UnityEngine.Transform,string) at (wrapper dynamic-method) CookingStation.DMD<CookingStation::UpdateVisual>(CookingStation,bool) at CookingStation.UpdateCooking () [0x0017b] in <756c340c98604b74a98c3197ae588e90>:0 and some fires not being lit, with the hearth (at least) looking like it's being rained on. I can check which specifically if it's helpful.
If you need any more info, ping me in discord (Same name). We share more than a couple right now. I'm just running with it disabled (nothing broke further, fires started back up)
Edit: thought to include a current r2 code: 018bac96-e635-e92d-36f8-97261b0d6739
Anyone else getting their kilns, smelters, and blast furnaces "stuck" when exiting and reloading the game? I have the break down the thing and rebuild it to get it started again.. I cant figure out what mod is doing it.
actually it turned out to be aedens mod interacting with this mod: https://valheim.thunderstore.io/package/Smoothbrain/ConversionSizeAndSpeed/
basically both mods work fine independently of each other, but together they were causing the issue. I had a heck of a time trying to find this, as I had not considered this scenario at first. I reached out to the author on his github but he was not interested in "supporting" aedens mod... A bit passive aggressive really. Anyways you can guess what QOL mod I kept. ;)
It might be worthwhile seeing what this bug actually is from a coders point of view.. Not so much to fix it, but to avoid introducing the same sort of issue... Its very weird that a craft from containers mod would impact something that affecting smelter behavior like this.
LOL, they took a bit to figure out and introduced a hideous bug that crashed games and servers but all that has been fixed.
The odd thing is this.. In the game the Iron Cooking Station... (the thing you hang meat on) is considered the same as the oven. This follows the same logic as the windmill and spinning wheel being a smelter in the game code. I don't get either but whatever.
The problem is when I go to check for smoke, clearly the Iron Cooking Station doesn't have smoke because it's a cooking rack not an oven. The mod says.. Check for smoke and the rack is like... I don't have smoke. Then it throw a null exception error which spams the logs and causes huge FPS problems. So the fix is to ask the game if the item is an oven before removing the smoke. If it's not the oven then it moves on and disregards.
Anyways all that to say... It works and thanks for using my mod.
There has been some reports of the version checker for servers not working. I can confirm this is a thing but not consistently. Regardless I have fixed the bug and will upload a version here later on. For now, turn off the client checking if you cannot connect to servers.
Chicken legs, few minor things, just looking at screenshot: - metal vs iron - hanging vs ceiling And if you accept wishes, could we get smoke on/off option? Possibly per item? I like both mods (this and torches), and love it combined now, but I mostly want the "always lit", sometimes "on timer", and mostly don't mind the challenge of smoke. First two are now perfect, but I'd feel better if some smoke could be returned :)
Good work and don't let it stop working please! :)
Edit: and might want to pin your own post to the top
The wording is easily fixable. The request for smoke and no smoke is pretty easy to do. Not many items have smoke anyways. Torches will get an upgrade soon with a new config and cleaned up code. I have a few more that need work and can maybe look at this at that point. Thanks again for the response.
-Edit the naming has been fixed. I'll give it a few days to see if any bugs crop up before updating the version here. Thanks again.
Just to confirm, works great, all of it! And I use all options ;D some smoke, some not, some lit, some on timer, and everything is as expected. Plus, one less mod to keep an eye on now that everything is in this one :) Thank you again!
2.1.0 Release - Added the ability to turn back on the smoke for some items. - Fixed a few bugs with the Timed Torches feature - Tested with some custom items.
Configuration options picture is on the main page of the mod.
One question for you, was NoSmoke support added for ovens? I thought that was a feature with 2.0.0 but they still seem to be smoking with the 2.1.0 fix.
Edit: Gotcha, thanks for the response. We like using your mod to increase FPS, as the smoke is really performance heavy in Valheim for some reason. Really it's up to you if you feel like adding it in or not - you've already done so much, and we appreciate the mod as is!
No the ovens just smoke regardless. I've never turned them off. I thought about it but the smoke is not really an issue. The ovens don't care if the smoke is blocked so I usually just cover it up. I guess I could maybe.. IDK, I haven't really ever looked at it.
-Edit I might take a look tomorrow. I think this is a relatively easy fix. I believe the smoke is a child object of the cooking station like the brazier, but I can fix that if needed.
That would be awesome! If it's too much hassle please don't sweat it though - we can always just leave the ovens empty until we need to cook, that's what we've been doing so far.
Sorry if the feedback / requests are getting annoying! It's just been one of the most simple and useful mods for increasing performance on our Mistlands playthrough, and was a mod I had always hoped for on every other play through.
80 comments
Let me know if you have any issues and thanks again for using my mods.
[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
NoSmokeStayLit.Patches.FireplaceIsBurning_Patch.Postfix (Fireplace __instance, System.Boolean& __result, UnityEngine.GameObject& ___m_enabledObjectHigh, ZNetView& ___m_nview) (at <8bc0da42d5ff4d39aa8d95d9b9b51961>:0)
(wrapper dynamic-method) Fireplace.DMD<Fireplace::IsBurning>(Fireplace)
(wrapper dynamic-method) Fireplace.DMD<Fireplace::UpdateFireplace>(Fireplace)
[HarmonyPatch(typeof(Fireplace), "Awake")]
These are just not going to work together. If you are just looking to take away the smoke, maybe you can use my No Smoke Simplified mod
Reporting that the "keep fueled" option for stone ovens appears to be non-functional as of the May 20th update to the mod.EDIT: Disregard about the ovens. Deconstructing and reconstructing them appears to have fixed this issue. It also does not appear that there is support for either the firepit purchased from Hildir, or the blue flame standing brazier.Thanks in advance for looking in on this!
That would add those to the are you want.
NullReferenceException: Object reference not set to an instance of an object
at NoSmokeStayLit.Patches.KeepFueledPatch+Fireplace_UpdateFireplace_Patch.Fireplace_UpdateFireplace (Fireplace __instance, ZNetView& ___m_nview) [0x00014] in <c064c06613fd42688146a60faa5b49c1>:0
at (wrapper dynamic-method) Fireplace.DMD<Fireplace::UpdateFireplace>(Fireplace)
any idea how to fix
- Blue Standing Brazier
- Firepit Iron
I don't know if it's from the (very) recent update, or a new interaction, but this mod no longer works for me, throwing lots of:
MissingMethodException: Method not found: UnityEngine.Transform .Utils.FindChild(UnityEngine.Transform,string)
andat (wrapper dynamic-method) Fireplace.DMD<Fireplace::IsBurning>(Fireplace)
at (wrapper dynamic-method) Fireplace.DMD<Fireplace::UpdateFireplace>(Fireplace)
MissingMethodException: Method not found: UnityEngine.Transform .Utils.FindChild(UnityEngine.Transform,string)
and some fires not being lit, with the hearth (at least) looking like it's being rained on. I can check which specifically if it's helpful.at (wrapper dynamic-method) CookingStation.DMD<CookingStation::UpdateVisual>(CookingStation,bool)
at CookingStation.UpdateCooking () [0x0017b] in <756c340c98604b74a98c3197ae588e90>:0
If you need any more info, ping me in discord (Same name). We share more than a couple right now. I'm just running with it disabled (nothing broke further, fires started back up)
Edit: thought to include a current r2 code:
018bac96-e635-e92d-36f8-97261b0d6739
This is now fixed in 2.3.1 posted tonight. Let me know if you need anything else.
basically both mods work fine independently of each other, but together they were causing the issue. I had a heck of a time trying to find this, as I had not considered this scenario at first. I reached out to the author on his github but he was not interested in "supporting" aedens mod... A bit passive aggressive really. Anyways you can guess what QOL mod I kept. ;)
It might be worthwhile seeing what this bug actually is from a coders point of view.. Not so much to fix it, but to avoid introducing the same sort of issue... Its very weird that a craft from containers mod would impact something that affecting smelter behavior like this.
The odd thing is this.. In the game the Iron Cooking Station... (the thing you hang meat on) is considered the same as the oven. This follows the same logic as the windmill and spinning wheel being a smelter in the game code. I don't get either but whatever.
The problem is when I go to check for smoke, clearly the Iron Cooking Station doesn't have smoke because it's a cooking rack not an oven. The mod says.. Check for smoke and the rack is like... I don't have smoke. Then it throw a null exception error which spams the logs and causes huge FPS problems. So the fix is to ask the game if the item is an oven before removing the smoke. If it's not the oven then it moves on and disregards.
Anyways all that to say... It works and thanks for using my mod.
- metal vs iron
- hanging vs ceiling
And if you accept wishes, could we get smoke on/off option? Possibly per item? I like both mods (this and torches), and love it combined now, but I mostly want the "always lit", sometimes "on timer", and mostly don't mind the challenge of smoke. First two are now perfect, but I'd feel better if some smoke could be returned :)
Good work and don't let it stop working please! :)
Edit: and might want to pin your own post to the top
-Edit the naming has been fixed. I'll give it a few days to see if any bugs crop up before updating the version here. Thanks again.
2.1.0 Release
- Added the ability to turn back on the smoke for some items.
- Fixed a few bugs with the Timed Torches feature
- Tested with some custom items.
Configuration options picture is on the main page of the mod.
One question for you, was NoSmoke support added for ovens? I thought that was a feature with 2.0.0 but they still seem to be smoking with the 2.1.0 fix.
Edit: Gotcha, thanks for the response. We like using your mod to increase FPS, as the smoke is really performance heavy in Valheim for some reason. Really it's up to you if you feel like adding it in or not - you've already done so much, and we appreciate the mod as is!
-Edit I might take a look tomorrow. I think this is a relatively easy fix. I believe the smoke is a child object of the cooking station like the brazier, but I can fix that if needed.
Sorry if the feedback / requests are getting annoying! It's just been one of the most simple and useful mods for increasing performance on our Mistlands playthrough, and was a mod I had always hoped for on every other play through.